Script Commands Bug Fixes

じ☆ve冰风

Bug Fixes for Both of RMXP's Interpreter's Script Commands​

Introduction

For ages we've known very well that the RMXP Interpreter class had an issue with command_355 aka the script event command. It has to evaluate the result of a script pasted as mere text in a very small window.

The problem was that certain non truthy values, anything that doesn't return true as end result, might get ignored by the game engine. This part and its related solution are nothing new in the XP community and I just "copied & pasted" that centuries old solution here.

Nonetheless, that's not all this scriptlet has to offer. I was discussing some issues with XP in a VX ACE channel when I noticed there was another bug that usually got ignored in RMXP. It was the script condition in the conditional branch event command! Shocked

The issue is very simple. You open the conditional branch and choose the script condition and type something there that's supposed to return a boolean value. (No if conditional reserved term is required there.) Now you'd expect me to tell you that it had the same issue the script command has... but nope, that's not the case here.

Both a truthy (true) and a falsey (false) value are fine and work just as intended. Yet, here comes the dreadful nil value into play!

Whenever your call returns a nil, your check becomes invalid and the engine simply skips it. Just like that, guys!


Don't worry pals!

The scriptlet below has come to Save-Point to solve that issue! :issue:

The Script

                Ruby:       

1. # * Bug Fixes for Both of RMXP's Interpreter's Script Commands * #
2. #   2025-02-12
3. #   Result: You won't get any more issues with comannds returning nil values!
5. class Interpreter
6.   # * Conditional Branch * #
7.   # Altered the Script Condition at the very end of this command
8.   def command_111
9.     # Initialize local variable: result
10.     result = false
11.     case @parameters[0]
12.     when 0  # switch
13.       result = ($game_switches[@parameters[1]] == (@parameters[2] == 0))
14.     when 1  # variable
15.       value1 = $game_variables[@parameters[1]]
16.       if @parameters[2] == 0
17.         value2 = @parameters[3]
18.       else
19.         value2 = $game_variables[@parameters[3]]
20.       end
21.       case @parameters[4]
22.       when 0  # value1 is equal to value2
23.         result = (value1 == value2)
24.       when 1  # value1 is greater than or equal to value2
25.         result = (value1 >= value2)
26.       when 2  # value1 is less than or equal to value2
27.         result = (value1 <= value2)
28.       when 3  # value1 is greater than value2
29.         result = (value1 > value2)
30.       when 4  # value1 is less than value2
31.         result = (value1 < value2)
32.       when 5  # value1 is not equal to value2
33.         result = (value1 != value2)
34.       end
35.     when 2  # self switch
36.       if @event_id > 0
37.         key = [$game_map.map_id, @event_id, @parameters[1]]
38.         if @parameters[2] == 0
39.           result = ($game_self_switches[key] == true)
40.         else
41.           result = ($game_self_switches[key] != true)
42.         end
43.       end
44.     when 3  # timer
45.       if $game_system.timer_working
46.         sec = $game_system.timer / Graphics.frame_rate
47.         if @parameters[2] == 0
48.           result = (sec >= @parameters[1])
49.         else
50.           result = (sec <= @parameters[1])
51.         end
52.       end
53.     when 4  # actor
54.       actor = $game_actors[@parameters[1]]
55.       if actor != nil
56.         case @parameters[2]
57.         when 0  # in party
58.           result = ($game_party.actors.include?(actor))
59.         when 1  # name
60.           result = (actor.name == @parameters[3])
61.         when 2  # skill
62.           result = (actor.skill_learn?(@parameters[3]))
63.         when 3  # weapon
64.           result = (actor.weapon_id == @parameters[3])
65.         when 4  # armor
66.           result = (actor.armor1_id == @parameters[3] or
67.                     actor.armor2_id == @parameters[3] or
68.                     actor.armor3_id == @parameters[3] or
69.                     actor.armor4_id == @parameters[3])
70.         when 5  # state
71.           result = (actor.state?(@parameters[3]))
72.         end
73.       end
74.     when 5  # enemy
75.       enemy = $game_troop.enemies[@parameters[1]]
76.       if enemy != nil
77.         case @parameters[2]
78.         when 0  # appear
79.           result = (enemy.exist?)
80.         when 1  # state
81.           result = (enemy.state?(@parameters[3]))
82.         end
83.       end
84.     when 6  # character
85.       character = get_character(@parameters[1])
86.       if character != nil
87.         result = (character.direction == @parameters[2])
88.       end
89.     when 7  # gold
90.       if @parameters[2] == 0
91.         result = ($game_party.gold >= @parameters[1])
92.       else
93.         result = ($game_party.gold <= @parameters[1])
94.       end
95.     when 8  # item
96.       result = ($game_party.item_number(@parameters[1]) > 0)
97.     when 9  # weapon
98.       result = ($game_party.weapon_number(@parameters[1]) > 0)
99.     when 10  # armor
100.       result = ($game_party.armor_number(@parameters[1]) > 0)
101.     when 11  # button
102.       result = (Input.press?(@parameters[1]))
103.     when 12  # script
104.       result = eval(@parameters[1])
105.     end
106.     # Store determinant results in hash
107.     # Added pos variable for the sake of convenience
108.     pos = @list[@index].indent
109.     # Bug Fix - Turn any nil value into false by default
110.     @branch[pos] = !!result
111.     # If determinant results are true
112.     if @branch[pos]
113.       # Delete branch data
114.       @branch.delete(pos)
115.       # Continue
116.       return true
117.     end
118.     # If it doesn't meet the conditions: command skip
119.     return command_skip
120.   end
121.   # * Script Event Command * #
122.   # Just a small variant of a very old bug fix published by somebody else
123.   def command_355
124.     # Set first line to script
125.     script = @list[@index].parameters[0] + "\n"
126.     # Loop
127.     loop do
128.       # If next event command is second line of script or after
129.       if @list[@index+1].code == 655
130.         # Add second line or after to script
131.         script += @list[@index+1].parameters[0] + "\n"
132.       # If event command is not second line or after
133.       else
134.         # Abort loop
135.         break
136.       end
137.       # Advance index
138.       @index += 1
139.     end
140.     # Evaluation
141.     result = eval(script)
142.     # Removed Several Lines Here Before Continue
143.     return true
144.   end
145. end

复制代码

Infrequently Asked Questions

Q: Has anybody else posted anything like this before?
A: Who knows? In any case I preferred to leave the script here just in case anybody fiddling with RMXP ever needs it.

Terms & Conditions

You can do whatever you want with it, I just built something upon somebody else's work and that's it.


本贴来自国际rpgmaker官方论坛作者:kyonides处,因国际论坛即将永久关站,为了存档多年珍贵资料,署名转载到本论坛存档,由于官方帖子为英文原帖，需要中文翻译请点击论坛顶部切换语言为中文就可以将帖子翻译成中文浏览,方便大家随时查看,原文地址：https://forums.rpgmakerweb.com/threads/script-commands-bug-fixes.154416/